fix: handle SIGTERM gracefully on unix#1278
fix: handle SIGTERM gracefully on unix#1278halaney wants to merge 1 commit intokubernetes:masterfrom
Conversation
We weren't catching SIGTERM and cancelling our context, so the go
runtime would have us exit with a non-zero code when the signal was
received. Let's catch it and try to exit gracefully.
i.e. before:
(...)
I0508 11:08:00.426917 1787442 log_monitor.go:237] Initialize condition generated: []
^C
$ echo $?
130
and now:
(...)
I0508 11:07:42.150562 1787146 log_monitor.go:237] Initialize condition generated: []
^C
I0508 11:07:43.372093 1787146 log_monitor.go:123] Stop log monitor /tmp/npd-test.json
I0508 11:07:43.652876 1787146 log_watcher.go:104] Stop watching filelog
I0508 11:07:43.652923 1787146 log_monitor.go:144] Log monitor stopped: /tmp/npd-test.json
$ echo $?
0
|
Hi @halaney. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: halaney The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
We weren't catching SIGTERM and cancelling our context, so the go runtime would have us exit with a non-zero code when the signal was received. Let's catch it and try to exit gracefully.
i.e. before:
and now: